Skip to content

[python] Encode list query params#20148

Merged
wing328 merged 2 commits intoOpenAPITools:masterfrom
jops-wtakase:bugfix/17688_encode_list_query_params
Nov 26, 2024
Merged

[python] Encode list query params#20148
wing328 merged 2 commits intoOpenAPITools:masterfrom
jops-wtakase:bugfix/17688_encode_list_query_params

Conversation

@jops-wtakase
Copy link
Contributor

@cbornet (2017/09) @tomplus (2018/10) @krjakbrjak (2023/02) @fa0311 (2023/10) @multani (2023/10)

fix #17688

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

…ydantic 2.10+

Pydantic 2.10+ introduced changes to validation error messages,
requiring updates to the affected test cases.
@wing328
Copy link
Member

wing328 commented Nov 26, 2024

lgtm. thanks for the fix

@wing328 wing328 merged commit 7b35613 into OpenAPITools:master Nov 26, 2024
nopcoder added a commit to treeverse/openapi-generator that referenced this pull request Feb 12, 2025
- Fixing python sdk based on OpenAPITools#20148
- Generated markdown fix for python doc we required
nopcoder added a commit to treeverse/lakeFS that referenced this pull request Feb 12, 2025
- Update fixes from v7.0.1
- Apply patch for python - Encode list query params (#20148)[OpenAPITools/openapi-generator#20148]
- Minor Python markdown spaces for the docs
nopcoder added a commit to treeverse/lakeFS that referenced this pull request Feb 18, 2025
* Upgrade api-codegen to v7.0.1.1

- Update fixes from v7.0.1
- Apply patch for python - Encode list query params (#20148)[OpenAPITools/openapi-generator#20148]
- Minor Python markdown spaces for the docs

* Re-apply build after pusing a fix to the api-codegen code

* Update test config to reflect the new generated code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] [PYTHON] Datetime params not encoded for request when defined as a list

2 participants