PHP8.4 comptible, php-symfony resources#20162
Merged
wing328 merged 3 commits intoOpenAPITools:masterfrom Nov 24, 2024
Merged
Conversation
Contributor
Author
Member
|
thanks for the PR can you please follow step 3 to update the samples? |
Contributor
Author
|
@wing328 run script, but nothing chages |
Contributor
Author
Contributor
Author
|
after approval, I will check this jobs |
1a34f46 to
fbf73b1
Compare
Member
|
can you please review the CI errors when you've time? |
Contributor
Author
|
@wing328 CI all check passed |
Member
|
@dmnlk just merged. thanks for the contribution. have a nice weekend |
wing328
reviewed
Nov 24, 2024
| php: | ||
| - "8.1" | ||
| - "8.2" | ||
| - "8.3" |
Member
There was a problem hiding this comment.
thanks for updating the workflow.
shall we test with 8.4 as well? or there're pending issues that need to be resolved before the output works with 8.4?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)add PHP 8.4 support
https://www.php.net/releases/8.4/en.php
In PHP 8.4, when using default arguments set to null, you are required to specify a type hint that includes either nullable or a union type with null. If this is not specified, a deprecated error will be displayed starting in PHP 8.4. This change is being addressed.
https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated
Additionally, matrix build settings have been added to ensure the project is built across multiple PHP versions.