Improved Elixir Atom Generation#20229
Merged
wing328 merged 3 commits intoOpenAPITools:masterfrom Dec 6, 2024
Merged
Conversation
* Refine the regular expression for atoms The original regex incorrectly matched `@atom` (unquoted atoms cannot begin with @). However, through testing with `iex`, it also turns out that the atom `:@` is legal. The following atoms will now be quoted that would have been incorrectly not quoted: - `:@type`
Member
|
@drewble thanks for the PR I just merged #20236 to create a seaprate spec to test Elixir client generator. Can you please merge the latest into your branch and add a test or 2 in the test spec(modules/openapi-generator/src/test/resources/3_0/elixir/petstore-with-fake-endpoints-models-for-testing.yaml), and then regenerate the samples? |
Contributor
Author
|
@wing328 I believe I have completed the updates as requested, with additions to the test spec, and an additional ExUnit test for the new |
Member
|
tested locally and the result is good |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current regex incorrectly matches
@atom(unquoted atoms cannot begin with @). However, through testing withiex, it also turns out that the atom:@is legal.The following atoms will now be quoted that would have been incorrectly not quoted:
:"@type"@mrmstn
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)