fix (DefaultGenerator): Handle "$ref" parameter reference to identify parameter ID (#20239)#20240
Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom Dec 5, 2024
Conversation
6 tasks
Member
|
thanks for the PR cc @OpenAPITools/generator-core-team |
Member
|
tested locally to confirm the fix. let's give it a try i'll try to add a test later |
5 tasks
Member
|
update: merged #20256 to add a test covering the issue moving forward |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix proposal for #20239
Use
reffield when filled in place of missingname:into avoid collision onto generated id (when $ref is present, it generate systemicallynull:nullID)So, with fix, in place of generating a missing parameter onto function prototype:
It now generated the correct list:
PR checklist
master(upcoming7.x.0minor release)