[PHP][php-nextgen] Fix usage of enums in parameters (Fix #20086)#20294
Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom Dec 16, 2024
Merged
[PHP][php-nextgen] Fix usage of enums in parameters (Fix #20086)#20294wing328 merged 1 commit intoOpenAPITools:masterfrom
wing328 merged 1 commit intoOpenAPITools:masterfrom
Conversation
wing328
reviewed
Dec 14, 2024
| // query params | ||
| $queryParams = array_merge($queryParams, ObjectSerializer::toQueryValue( | ||
| ${{paramName}}, | ||
| ${{paramName}}{{#isEnumRef}}->value{{/isEnumRef}}, |
Member
There was a problem hiding this comment.
what about inline enum? shall we use isEnumOrRef instead?
Contributor
Author
There was a problem hiding this comment.
An inline enum for that would look like this, right?
paths:
/path-int/{p}:
get:
parameters:
- name: p
in: path
required: true
description: Integer option in path
schema:
type: integer
enum:
- 0
- 1
- 2
x-enum-varnames:
- ZERO
- ONE
- TWO
responses:
'200':
description: OKThat does not generate any model classes or constants in the php-nextgen generator.
The type of the function parameter is just int or string so adding ->value would be incorrect.
6 tasks
timon-sbr
pushed a commit
to timon-sbr/openapi-generator
that referenced
this pull request
Mar 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using enums in path, header or query parameters with the php-nextgen generator currently causes type errors like the following:
Example spec: https://gist.github.com/JulianVennen/237b96487d45bbe24b3b174e0e7a758c
This PR fixes those errors by passing the value to these functions instead.
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)@jebentier @dkarlovi @mandrean @jfastnacht @ybelenko @renepardon