[FIX][PHP-NEXTGEN] Missing tagged union discriminator literal (#20343)#20356
[FIX][PHP-NEXTGEN] Missing tagged union discriminator literal (#20343)#20356wing328 merged 2 commits intoOpenAPITools:masterfrom brianferri:master
Conversation
|
@brianferri thanks for the PR can you please briefly describe the issue? |
Of course, @wing328. The PHP generators, when generating tagged unions dont generate all the correct discriminator mapping values. This is because the part that should have handled this didn't exist previously in the generic model template. The PR adds the missing part of the template for the generation of mapped models for the discriminator values in the case of a tagged union model (This is something that other generators already do, tested with Java, python, typescript generators) |
|
FYI @JulianVennen as well who's been making a lot of improvements to php-nextgen client generator. |
…ITools#20343) (OpenAPITools#20356) * fix: OpenAPITools#20343 * chore: apply correct formatting chore: build and package --------- Co-authored-by: Christian Ascone <ascone.christian@gmail.com> --------- Co-authored-by: Christian Ascone <ascone.christian@gmail.com>
PR checklist
Read the contribution guidelines.
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
Run the following to build the project and update samples:
(For Windows users, please run the script in Git BASH)
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
File the PR against the correct branch:
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
@jebentier (2017/07), @dkarlovi (2017/07), @mandrean (2017/08), @jfastnacht (2017/09), @ybelenko (2018/07), @renepardon (2018/12)