Skip to content

[swift] fix typos, minor code format enhancement#20387

Merged
wing328 merged 3 commits intomasterfrom
swift-update
Dec 31, 2024
Merged

[swift] fix typos, minor code format enhancement#20387
wing328 merged 3 commits intomasterfrom
swift-update

Conversation

@wing328
Copy link
Member

@wing328 wing328 commented Dec 30, 2024

  • fix typo in option
  • fix uuid typo in swift codegen and templates
  • fix typo in templates (minium => minimum)
  • minor code format improvement

based on #19470

credits: @NathanBaulch

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

cc
@jgavris (2017/07) @ehyche (2017/08) @Edubits (2017/09) @jaz-ah (2017/09) @4brunu (2019/11) @dydus0x14 (2023/06)

@wing328 wing328 changed the title [swift] fix typo in option, minor code format enhancement [swift] fix typos, minor code format enhancement Dec 30, 2024
Copy link
Contributor

@4brunu 4brunu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me 👍

@wing328 wing328 merged commit 8f4cfa3 into master Dec 31, 2024
37 checks passed
@wing328 wing328 deleted the swift-update branch December 31, 2024 08:51
timon-sbr pushed a commit to timon-sbr/openapi-generator that referenced this pull request Mar 13, 2025
* fix typo in swift option, minor code format enhancement

* fix uuid typo in swift codegen and template

* fix typo minium
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants