[Rust-Axum] Implement support for Basic and Bearer auth in Claims#20584
Merged
wing328 merged 13 commits intoOpenAPITools:masterfrom Feb 19, 2025
Merged
Conversation
51f6e61 to
73be821
Compare
14a8e95 to
a181f49
Compare
Comment on lines
+20
to
+21
| + apis::ApiAuthBasic<Claims = C> | ||
| + apis::ApiAuthBasic<Claims = C> |
Contributor
Author
There was a problem hiding this comment.
This is odd, but it works. This happens if both a basic and bearer auth are defined.
Contributor
There was a problem hiding this comment.
Let make it up later. We can if else in mustache to ensure that only one trait is rendered
Contributor
Author
Member
|
if no feedback from anyone, i'll merge it on coming Wed. |
linxGnu
approved these changes
Feb 19, 2025
Comment on lines
+20
to
+21
| + apis::ApiAuthBasic<Claims = C> | ||
| + apis::ApiAuthBasic<Claims = C> |
Contributor
There was a problem hiding this comment.
Let make it up later. We can if else in mustache to ensure that only one trait is rendered
Member
|
@linxGnu thanks for reviewing the change when you've time, can you please PM me via Slack? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR creates a new
ApiAuthBasicClaim trait that is used for basic and bearer authorization.An example implementation looks like this:
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples, as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)