[Go]Add Value suffix to Golang types#20645
Closed
Sander0542 wants to merge 1 commit intoOpenAPITools:masterfrom
Sander0542:fix/golang-type-names
Closed
[Go]Add Value suffix to Golang types#20645Sander0542 wants to merge 1 commit intoOpenAPITools:masterfrom Sander0542:fix/golang-type-names
Sander0542 wants to merge 1 commit intoOpenAPITools:masterfrom
Sander0542:fix/golang-type-names
Conversation
Contributor
Author
|
Closed in favour of #20663 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Go client library generates Parameter structs for OneOf and AnyOf types. When one of the types is a string, then the property name will be
String. This prevents us from creating aString()method which can be used with thefmtpackage.By adding a Value suffix to the property names, we don't change any logic while allowing for more flexibility with the generated client.
This however requires existing clients to update calls to the implementations they made.
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)@antihax (2017/11) @grokify (2018/07) @kemokemo (2018/09) @jirikuncar (2021/01) @ph4r5h4d (2021/04) @lwj5 (2023/04)