[go-server] move errMsg helpers to helpers file#20876
Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom Mar 15, 2025
Merged
[go-server] move errMsg helpers to helpers file#20876wing328 merged 1 commit intoOpenAPITools:masterfrom
wing328 merged 1 commit intoOpenAPITools:masterfrom
Conversation
Member
|
thanks for the follow-up PR quick question: shouldn't the current output (go code) fail to compile if these constants are missing? |
Contributor
Author
|
They won't be missing, they'll be in the helper file instead of router since the helper code is using it. But yeah, if I was deleting them then go would throw an error for vars not existing when it went to compile. It would have also been caught by the tests since go compiles then too Their placement works in any of these files since they're part of the package. That's why the version in master still works since helper file can use the vars in router file. |
Member
|
thanks for the explanation will merge it over the weekend if no one else has further feedback/question |
Contributor
Author
|
Thank you @wing328 ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #20817
Missed moving the errMsgs from the router to the helper file in this MR: #20823
Apologies about that! This MR is to complete the move so everything helper is together and router is standalone
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)@antihax (2017/11) @grokify (2018/07) @kemokemo (2018/09) @jirikuncar (2021/01) @ph4r5h4d (2021/04) @lwj5 (2023/04)