[rust] Fix for allOf multi model with only metadata fields#20892
Merged
wing328 merged 5 commits intoOpenAPITools:masterfrom Apr 26, 2025
Merged
[rust] Fix for allOf multi model with only metadata fields#20892wing328 merged 5 commits intoOpenAPITools:masterfrom
wing328 merged 5 commits intoOpenAPITools:masterfrom
Conversation
wing328
reviewed
Mar 23, 2025
| schema.get$anchor() != null || | ||
| schema.getContentSchema() != null; | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
thanks for the PR
would it be better to put this method in the model util class as static method?
Contributor
Author
Member
|
please resolve the merge conflicts when you've time |
Contributor
Author
|
updated, thanks |
Member
|
merged. have a nice weekend |
5 tasks
Member
|
fyi. i've filed #21342 to refactor the logic into openapi noramlizer |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes one of the bugs reported in #20500.
The following schema will generate models with a
Vecwith the generic parameter causing compiler errors.Because the second parameter simply metadata that is not important to code generation we can simply ignore it.
NOTE: This fix does not add full support for
allOfwith multiple non-model types.PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)cc: @frol @farcaller @richardwhiuk @paladinzh @jacob-pro
cc @OpenAPITools/generator-core-team @wing328 since this fix may change the behavior of other clients