fix hashCode and equals for AdditionalProperties and generateAliasAsM…#20902
fix hashCode and equals for AdditionalProperties and generateAliasAsM…#20902jpfinne wants to merge 1 commit intoOpenAPITools:masterfrom
Conversation
martin-mfg
left a comment
There was a problem hiding this comment.
What happened to the changes in modules/openapi-generator/src/main/resources/Java/pojo.mustache? It seems they got lost - or are they not needed?
Other than this the changes look good to me.
'{{>libraries/xxx/additional_properties}} are only defined in the pojo.mustache for the individual libraries. Thanks for the review |
|
@martin-mfg @wing328 Is there anything that blocks the merge of this PR? |
Mainly the merge conflicts. Please resolve them when you have time. Other than this the PR looks good to me. So then we just need to wait for @wing328 to merge it. |
|
Hi @jpfinne! 👋 Thanks for the pull request! I recently also fixed how additional properties are handled by the |
Fix compilation error for hashcode #20795
(replace #20831 that have merge issues)
Equals also uses additionalProperties if present.
The fixes are for java feign/resttemplate/jersey2/jersey3/native/okhttp-gson/webclient and JavaSpring
@NilsDammenhayn
The generated code still uses the "new" way of 7.12.0
instead of
This PR only fixes the compilation error for resttemplate, webclient and feign
Microprofile still uses the extends HashMap
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)