[swift6] Add typed throws to Validation functions#20903
Merged
4brunu merged 1 commit intoOpenAPITools:masterfrom Mar 17, 2025
Merged
[swift6] Add typed throws to Validation functions#209034brunu merged 1 commit intoOpenAPITools:masterfrom
4brunu merged 1 commit intoOpenAPITools:masterfrom
Conversation
Member
|
https://app.bitrise.io/build/50334c36-d425-407b-85ff-43f35bf4f9fc can you please review the build failure when you've time? |
Contributor
Author
|
The alamofireLibrary project is already broken on the |
Contributor
|
The alamofireLibrary is locked into an old version prior to Alomofire migrating to Swift 6, which work with the openapi generator Swift 6 client, so it should not affect the pipelines. |
Contributor
|
I closed and reopened this PR to try to trigger the pipelines again. |
Contributor
|
CI is still failing, but I think this is not related to this PR. I will investigate a bit more. |
Contributor
|
I have built this project locally and it works. |
4brunu
approved these changes
Mar 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Swift 6 allows for the
throwskeyword to specify the type of error being thrown. In the case of Validation, this will save one unboxing/casting operation and make the result easier to use.PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)@jgavris (2017/07) @ehyche (2017/08) @Edubits (2017/09) @jaz-ah (2017/09) @4brunu (2019/11) @dydus0x14 (2023/06)