[dart-dio][timemachine] Bugfix: Ensure closing bracket when adding serializers#20908
Merged
wing328 merged 2 commits intoOpenAPITools:masterfrom Mar 19, 2025
Merged
Conversation
Contributor
|
LGTM, thanks! |
kuhnroyal
approved these changes
Mar 17, 2025
Contributor
Member
|
ci failure (already fixed in master) not related to this change |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using dart-dio with
timemachineleads to syntax error inlib/src/serializers.dart->Expected to find ')'It seems the bug was introduced here #9180 (see file), where there's a closing bracket for
{{#useDateLibCore}} ....... {{/useDateLibCore}}but not for{{#useDateLibTimeMachine}} ....... {{/useDateLibTimeMachine}}.Adding the bracket just before the
.buildto ensure it is always closed, independent of what's defined in previous lines...PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)@jaumard (2018/09) @josh-burton (2019/12) @amondnet (2019/12) @sbu-WBT (2020/12) @kuhnroyal (2020/12) @agilob (2020/12) @ahmednfwela (2021/08)