[feat] [protobuf] Improve protobuf generator with switch useSimplifiedEnumNames#21052
Merged
wing328 merged 6 commits intoOpenAPITools:masterfrom Apr 16, 2025
Merged
Conversation
andrewwilsonnew
commented
Apr 8, 2025
| } | ||
|
|
||
| private void testEnumValues(boolean simpleEnumValue) { | ||
| final Schema model = new Schema() |
andrewwilsonnew
commented
Apr 8, 2025
|
|
||
| private boolean wrapComplexType = true; | ||
|
|
||
| private boolean simpleEnumName = false; |
Author
There was a problem hiding this comment.
If you want to look at the output flip this flag and run the generator, but this is covered by unit tests
Contributor
There was a problem hiding this comment.
We could also test the output by adding the flag in bin/configs/protobuf-schema-config.yaml .
Member
|
thanks for the PR cc @lucy66hw as well |
lucy66hw
approved these changes
Apr 8, 2025
added 2 commits
April 9, 2025 09:35
Author
|
@wing328 ready to go |
lucy66hw
approved these changes
Apr 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#21054
@wing328 we generate wire classes with our protos so we'd like the enum names to be
FOOrather thanTEST_STRING_ENUM_FOO. I've added a switch useSimplifiedEnumNames (default old value). Any chance we could get this into the patch?PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)