[fix][elixir] simplify connection module#21158
Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom May 4, 2025
Merged
Conversation
304ba31 to
5826c14
Compare
5826c14 to
e363748
Compare
e363748 to
e1b49a2
Compare
Member
|
thanks for the pr we can consider this a bug fix to start with. if later users need the old behaviour, we can try to come up with a way to fallback |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR simplifies the generated
Connectionmodule according to the discussion here. The new approach is more idiomatic and improves the maintainability of the generator.Additionally, it resolves the issue reported in #20562 by removing the problematic function specification from the generated code. The issue can be reproduced using Stripe's OpenAPI specification, available here.
With these changes, #15075 becomes unnecessary.
I considered targeting the
8.0.xbranch, but since the Elixir generator is still in alpha and this change also fixes a known issue, I believe it makes more sense to targetmasterdirectly. What do you think?As usual, curious to hear your thoughts @mrmstn and @wing328 😊
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)