[Php-Symfony] add text/plain and image/png endpoint in petstore.yaml#21286
Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom May 16, 2025
gturri:dev
Merged
[Php-Symfony] add text/plain and image/png endpoint in petstore.yaml#21286wing328 merged 1 commit intoOpenAPITools:masterfrom gturri:dev
wing328 merged 1 commit intoOpenAPITools:masterfrom
gturri:dev
Conversation
PR #21261 added support for endpoint with response of type text/plain or even image/png. This commit adds such endpoint so that: - the way those are supported is clearer (as it is now directly visible in the generated sample files) - if a future commit impacts this part of the generation it will be easier to assess that impact
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)PR #21261 added support for endpoints with response of type text/plain or even image/png.
This commit adds such endpoints (and the subsequently generated samples) so that:
(nb: first time I'm editing an openapi specification in that repo, I hope I'm doing that commit correctly. Please let me know if I'm doing something wrong, or missing something)
Ping PHP committee: @jebentier @dkarlovi @mandrean @jfastnacht @ybelenko @renepardon