[BUG][Kotlin] fix: kotlin code generator should sanitize enum values according to convention#21459
Merged
4brunu merged 4 commits intoOpenAPITools:masterfrom Jun 25, 2025
msnteixeira:master
Merged
[BUG][Kotlin] fix: kotlin code generator should sanitize enum values according to convention#214594brunu merged 4 commits intoOpenAPITools:masterfrom msnteixeira:master
4brunu merged 4 commits intoOpenAPITools:masterfrom
msnteixeira:master
Conversation
Contributor
|
Hi, CI is failing, can you please check and fix it? Thanks |
Contributor
Author
Contributor
|
Yes please, to see if CI passes |
Contributor
Author
|
@4brunu Can I get a workflow approval from a maintainer? Aside from building the samples I also made these changes since I was getting the same error as #21450. This should probably fix the issue, though it should be handled in a separate PR. |
This reverts commit 51a55bc.
Contributor
Author
Contributor
|
Done |
Contributor
|
Thanks for the contribution 👍 |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In summary, the Kotlin code generator is not sanitizing enum values correctly. This occurs for hyphenated values where it gets translated to Minus. This attempts to fix #21181
@wing328 @dr4ke616 @karismann @Zomzog @andrewemery @4brunu @yutaka0m @stefankoppier @e5l
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)