Fix compiler error in angular typescript codegen#2149
Merged
wing328 merged 2 commits intoOpenAPITools:masterfrom Feb 14, 2019
macjohnny:bugfix/2147-typescript-angular-void-truthiness
Merged
Fix compiler error in angular typescript codegen#2149wing328 merged 2 commits intoOpenAPITools:masterfrom macjohnny:bugfix/2147-typescript-angular-void-truthiness
wing328 merged 2 commits intoOpenAPITools:masterfrom
macjohnny:bugfix/2147-typescript-angular-void-truthiness
Conversation
Member
Author
Member
Author
|
cc @TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @nicokoenig (2018/09) @topce (2018/10) |
4 tasks
Member
Author
|
@wing328 could you please merge this one? it does not change any functionality but simply prevents a compilation error by disabling type checking in the particular part in the code. |
A-Joshi
pushed a commit
to ihsmarkitoss/openapi-generator
that referenced
this pull request
Feb 27, 2019
…penAPITools#2149) * OpenAPITools#2147: fix compiler error in angular typescript codegen * OpenAPITools#2147: generate samples
wing328
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.sh,./bin/security/{LANG}-petstore.shand./bin/openapi3/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,. Default:3.4.x,4.0.xmaster.Description of the PR
fixes #2147