Fix response model generation with ParseOptions.resolveResponses=true#21568
Merged
wing328 merged 2 commits intoOpenAPITools:masterfrom Jul 19, 2025
Merged
Fix response model generation with ParseOptions.resolveResponses=true#21568wing328 merged 2 commits intoOpenAPITools:masterfrom
wing328 merged 2 commits intoOpenAPITools:masterfrom
Conversation
stuart-masabi
approved these changes
Jul 15, 2025
Member
|
Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors. Let me know if you need help fixing it. |
995f16a to
1b97b41
Compare
needed by swagger-parser>=2.1.23, see swagger-api/swagger-parser#2127
1b97b41 to
9c920d7
Compare
Contributor
Author
@wing328 Thanks. Authorship should be fixed now. |
Member
|
please follow step 3 in the checklist to update the samples |
Member
|
tested locally and the result is good diff --git a/api/openapi.yaml b/api/openapi.yaml
index d7139ea..0be52a4 100644
--- a/api/openapi.yaml
+++ b/api/openapi.yaml
@@ -10,7 +10,11 @@ paths:
operationId: hello
responses:
"200":
- $ref: "#/components/responses/refResponse"
+ content:
+ application/json:
+ schema:
+ $ref: "#/components/schemas/hello_200_response"
+ description: a response specification `$ref`erenced from an operation
x-accepts:
- application/json
components:
@@ -19,10 +23,10 @@ components:
content:
application/json:
schema:
- $ref: "#/components/schemas/inline_object"
+ $ref: "#/components/schemas/hello_200_response"
description: a response specification `$ref`erenced from an operation
schemas:
- inline_object:
+ hello_200_response:
example:
responseProperty: responseProperty
properties:
thanks for the fix have a nice weekend |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolveResponsesis needed by swagger-parser>=2.1.23, see swagger-api/swagger-parser#2127with out this,
$referenced response models are not resolved by openapi-generator 7.14.0PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)