[Scala sttp] Fix header serialization for Optional values#21603
Merged
wing328 merged 3 commits intoOpenAPITools:masterfrom Aug 2, 2025
Merged
[Scala sttp] Fix header serialization for Optional values#21603wing328 merged 3 commits intoOpenAPITools:masterfrom
wing328 merged 3 commits intoOpenAPITools:masterfrom
Conversation
6 tasks
b44fa4a to
9b49804
Compare
Member
meanwhile we can consider that as an edge case and only start looking into it if users have such a use case |
…p the None value. If a value is present it is converted to an Option[String]
Member
|
is this ready for merge? if yes, i'll try to get it merged over the weekend after running some local tests |
Contributor
Author
|
Hi, I would say it is ready for merging give the small size of the changes. I had hoped that I would get additional input from the issue author, but not something I have received yet. |
Goopher
pushed a commit
to Goopher/openapi-generator
that referenced
this pull request
Sep 9, 2025
…ls#21603) * Adjust header serialization for Optional values * Add additional test verification to display the header type * Do not get a null value from an option if it is empty, but rather keep the None value. If a value is present it is converted to an Option[String]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #21602
Marked as a draft while attempting to find a proper solution for how to handle required header parameters that are complex (i.e., the header contains a
refrather than astring).PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)