[csharp] Ensure unique property names#21649
Merged
wing328 merged 9 commits intoOpenAPITools:masterfrom Aug 3, 2025
Merged
Conversation
Member
|
we suggest users to use name mapping options: https://github.com/openapitools/openapi-generator/blob/master/docs/customization.md#name-mapping to handle duplicated names in the output (we tried adding a numeric suffix before and it turned out no one wants to use a model with properties id1, id2, id3, etc even though it compiles) |
Contributor
Author
|
Why not both? Get it to compile and when they don't like the suffix then use the map. I will concede that numbering could be inconsistent if the yaml or java change, but it should definitely compile one way or another. |
Member
|
never said we shouldn't do both or not adding X different ways to handle such case just sharing what we went through and the feedback from users when trying to handle such case |
Goopher
pushed a commit
to Goopher/openapi-generator
that referenced
this pull request
Sep 9, 2025
* started fixing multiple issues * weather api builds * added docstring * ensure property names are unique * force pr gates to restart * force pr gates to restart * force pr gates to restart * force pr gates to restart
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial fix for #21585
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)