Fix #20304 : preserve sibling properties on $ref #21658
Closed
krumbs8749 wants to merge 6 commits intoOpenAPITools:masterfrom
Closed
Fix #20304 : preserve sibling properties on $ref #21658krumbs8749 wants to merge 6 commits intoOpenAPITools:masterfrom
krumbs8749 wants to merge 6 commits intoOpenAPITools:masterfrom
Conversation
Member
|
thanks for the pr when you've time, please resolve the merge conflicts and merge the latest master into your branch (that should fix the rust server CI failure) |
Member
|
update: I've filed #22364 to fix the issue. if when you've time, please kindly do a test. |
Member
|
just merged. #22364 please give it a try with the latest master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Core changes
$refare lost #20304mergeSiblingFields()function (inModelUtils) to copy every non-null OAS 3.1 sibling keyword from the wrapper onto the resolved definition, and createddeepCopy()helper to preserve concrete schema subtypes (so flags like isNull/isDate still work).Added tests:
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)