[BUG][CSHARP][GENERICHOST] Write enum values in expected JSON format#21698
Merged
wing328 merged 8 commits intoOpenAPITools:masterfrom Aug 9, 2025
Merged
[BUG][CSHARP][GENERICHOST] Write enum values in expected JSON format#21698wing328 merged 8 commits intoOpenAPITools:masterfrom
wing328 merged 8 commits intoOpenAPITools:masterfrom
Conversation
d3ab6db to
837c58b
Compare
20ff08b to
a1b41d1
Compare
a1b41d1 to
755f7d4
Compare
Contributor
Author
Contributor
|
Looks like an obvious improvement. There is another issue open that will require more changes here, so consider adding to the manual test at samples\client\petstore\csharp\generichost\net8\ManualPetstoreTests to ensure it works and continues to work. Thanks for the PR, love the help! |
34ddc56 to
e073c83
Compare
e073c83 to
bd30424
Compare
Member
|
@alec-petersen thanks for the PR @devhl-labs is this PR ready? if yes, i'll include it in the upcoming release due this weekend |
Contributor
|
Yup send it |
keepConcentration
added a commit
to keepConcentration/openapi-generator
that referenced
this pull request
Aug 10, 2025
Goopher
pushed a commit
to Goopher/openapi-generator
that referenced
this pull request
Sep 9, 2025
…penAPITools#21698) * Use ValueConverter method for enums to output in the correct JSON format * Fix doc comment * Update samples * Call ToString on return value of converter * Update samples * Update samples * Add test
keepConcentration
added a commit
to keepConcentration/openapi-generator
that referenced
this pull request
Sep 9, 2025
wing328
pushed a commit
that referenced
this pull request
Sep 10, 2025
…y1 fallback (#21931) * Add support for both string and object license formats in `pyproject.toml` for Python and Python-Pydantic generators. (#21619) * Generate the samples (#21698) * Generate the samples (#21698) * Remove Python-Pydantic-v1 license format tests (#21619) * Revert license format to string in Python-Pydantic-v1 samples (#21619)
Goopher
pushed a commit
to Goopher/openapi-generator
that referenced
this pull request
Sep 16, 2025
…t with poetry1 fallback (OpenAPITools#21931) * Add support for both string and object license formats in `pyproject.toml` for Python and Python-Pydantic generators. (OpenAPITools#21619) * Generate the samples (OpenAPITools#21698) * Generate the samples (OpenAPITools#21698) * Remove Python-Pydantic-v1 license format tests (OpenAPITools#21619) * Revert license format to string in Python-Pydantic-v1 samples (OpenAPITools#21619)
rajvesh
pushed a commit
to rajvesh/openapi-generator
that referenced
this pull request
Dec 25, 2025
…t with poetry1 fallback (OpenAPITools#21931) * Add support for both string and object license formats in `pyproject.toml` for Python and Python-Pydantic generators. (OpenAPITools#21619) * Generate the samples (OpenAPITools#21698) * Generate the samples (OpenAPITools#21698) * Remove Python-Pydantic-v1 license format tests (OpenAPITools#21619) * Revert license format to string in Python-Pydantic-v1 samples (OpenAPITools#21619)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21697. Uses the existing ValueConverter object that is generated for each enum.
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)