[BUG][rust-axum] Fix duplicate route operations when supplying multiple tags on a path with a camelCase param#21873
Merged
wing328 merged 2 commits intoOpenAPITools:masterfrom Sep 3, 2025
Conversation
…le tags on a path with a camelCase param
Member
|
thanks for the pr cc @linxGnu |
linxGnu
reviewed
Sep 3, 2025
Contributor
linxGnu
left a comment
There was a problem hiding this comment.
@KevinLiddle thank you for the PR.
Basically LGTM. Could you please run integration test with following command:
mvn clean && ./bin/generate-samples.sh bin/configs/manual/rust-axum-* && mvn integration-test -f samples/server/petstore/rust-axum/pom.xml
Contributor
Author
|
@linxGnu I ran that command and pushed the updated sample for rust-axum. Thanks for the quick review! |
Goopher
pushed a commit
to Goopher/openapi-generator
that referenced
this pull request
Sep 9, 2025
…le tags on a path with a camelCase param (OpenAPITools#21873) * [BUG][rust-axum] Fix duplicate route operations when supplying multiple tags on a path with a camelCase param * Update rust-axum sample
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same issue as #21144 but the fix for that issue did not take into account path names that are normalized for Rust conventions (camelCase param names turning into snake_case). This fixes that check to account for that difference.
Rust Committee: @frol @farcaller @richardwhiuk @paladinzh @jacob-pro @dsteeley
I didn't see a sample YAML file for rust-axum in the
bin/configs/directory. Let me know if there's something else I should do for that item in the PR checklist.PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)