fix(ruby-client): Fix incorrect boolean parsing in OneOf/AnyOf#21943
Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom Sep 11, 2025
Merged
Conversation
MWndrs
approved these changes
Sep 10, 2025
Changes the logic of parsing of OneOf/AnyOf to fix incorrect type coercion in OneOf/AnyOf contexts. The guard which checks whether typed_data is true-ish fails for booleans. If the oneOf includes a boolean type and the data is false then it will correctly parse this value as a boolean. However, the guard class will determine that false is not true-ish and therefore returns nil. So the result of the type coercion of false will be nil. This can result in problems when dealing with default true. For example how a false can turn into a true with defaults: 1. The API returns false 2. The type coercion determines false becomes nil 3. When storing this retrieved record with a default of true for this column the stored value is suddenly true while the API specifically returned false This fix removes this guard and will rely on the exception raised to return nil when type coercion fails.
7d6d788 to
0ac93a4
Compare
Member
|
thanks for the fix ci failure not related to this change. i'll address that later |
Goopher
pushed a commit
to Goopher/openapi-generator
that referenced
this pull request
Sep 16, 2025
…PITools#21943) Changes the logic of parsing of OneOf/AnyOf to fix incorrect type coercion in OneOf/AnyOf contexts. The guard which checks whether typed_data is true-ish fails for booleans. If the oneOf includes a boolean type and the data is false then it will correctly parse this value as a boolean. However, the guard class will determine that false is not true-ish and therefore returns nil. So the result of the type coercion of false will be nil. This can result in problems when dealing with default true. For example how a false can turn into a true with defaults: 1. The API returns false 2. The type coercion determines false becomes nil 3. When storing this retrieved record with a default of true for this column the stored value is suddenly true while the API specifically returned false This fix removes this guard and will rely on the exception raised to return nil when type coercion fails.
rajvesh
pushed a commit
to rajvesh/openapi-generator
that referenced
this pull request
Dec 25, 2025
…PITools#21943) Changes the logic of parsing of OneOf/AnyOf to fix incorrect type coercion in OneOf/AnyOf contexts. The guard which checks whether typed_data is true-ish fails for booleans. If the oneOf includes a boolean type and the data is false then it will correctly parse this value as a boolean. However, the guard class will determine that false is not true-ish and therefore returns nil. So the result of the type coercion of false will be nil. This can result in problems when dealing with default true. For example how a false can turn into a true with defaults: 1. The API returns false 2. The type coercion determines false becomes nil 3. When storing this retrieved record with a default of true for this column the stored value is suddenly true while the API specifically returned false This fix removes this guard and will rely on the exception raised to return nil when type coercion fails.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes the logic of parsing of OneOf/AnyOf to fix incorrect type coercion in OneOf/AnyOf contexts. The guard which checks whether typed_data is true-ish fails for booleans. If the oneOf includes a boolean type and the data is false then it will correctly parse this value as a boolean. However, the guard class will determine that false is not true-ish and therefore returns nil. So the result of the type coercion of false will be nil. This can result in problems when dealing with default true.
For example how a false can turn into a true with defaults:
This fix removes this guard and will rely on the exception raised to return nil when type coercion fails.
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)@cliffano (2017/07) @zlx (2017/09) @autopp (2019/02)