Fix php-slim4 API key authentication throwing exception#21962
Conversation
authenticatorConfig was being overwritten instead of having additional fields added. Changed the reqex from requiring leading whitespace to having it optional.
|
thanks for the pr please follow step 3 to update the samples |
Sorry, I'm not installing WSL on my machine. I can delete the PR. |
|
@PhotoKevin no worry. we can update it for you. did you test the fix using customized templates (e.g. -t via CLI) to confirm it works for your use cases? cc |
I didn't realize that was an option. I opened up the jar file and updated the mustache file. Probably the harder way but one I knew. |
authenticatorConfig was being overwritten instead of having additional fields added. Changed the reqex from requiring leading whitespace to having it optional.
authenticatorConfig was being overwritten instead of having additional fields added. Changed the reqex from requiring leading whitespace to having it optional.
to close #21958
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)