fix(kotlin-spring): add missing constructor parentheses for hashmap models#22029
Merged
wing328 merged 2 commits intoOpenAPITools:masterfrom Sep 27, 2025
Merged
Conversation
63dfae1 to
e30404e
Compare
…odels This commit fixes a bug in the kotlin-spring generator where models defined with additionalProperties would result in uncompilable code. The generated data class was missing the constructor invocation '()' when inheriting from a map type. This has been corrected to only add parentheses when the parent is a map. The existing samples have been regenerated to reflect this change.
e30404e to
10ee14a
Compare
rajvesh
pushed a commit
to rajvesh/openapi-generator
that referenced
this pull request
Dec 25, 2025
…odels (OpenAPITools#22029) * fix(kotlin-spring): add missing constructor parentheses for hashmap models This commit fixes a bug in the kotlin-spring generator where models defined with additionalProperties would result in uncompilable code. The generated data class was missing the constructor invocation '()' when inheriting from a map type. This has been corrected to only add parentheses when the parent is a map. The existing samples have been regenerated to reflect this change. * Trigger CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes a bug in the
kotlin-springgenerator where models defined with additionalProperties would result in uncompileable code. The generated data class was missing the constructor invocation '()' when inheriting from a map type.A new sample test case has been added to verify the fix and prevent regressions.
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)