[CSHARP] Add cache to efficiently lookup CodegenModel in csharp codegen to make csharp generator faster#22094
Merged
wing328 merged 2 commits intoOpenAPITools:masterfrom Oct 14, 2025
Conversation
Member
|
can you please merge the latest master into your branch? I believe this issue no longer happens with the latest master |
Member
|
Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors. Let me know if you need help fixing it. |
Member
|
Also cc @devhl-labs |
Contributor
|
Samples did not change so it should be fine. My only slight concern is regarding cache consistency, but we can send it. |
rajvesh
pushed a commit
to rajvesh/openapi-generator
that referenced
this pull request
Dec 25, 2025
…PITools#22094) Co-authored-by: ivan_leb <ivan_leb@mail.ru>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)The csharp generator works unacceptably slow (~ few hours) when it consumes a large enough spec file.
F.e. :
vi_json_openapi_specification_v8_0_3_0.json
Meanwhile any other generator works in a minute with the same spec.
To reproduce this behavior run
java -jar modules\openapi-generator-cli\target\openapi-generator-cli.jar generate -i vi_json_openapi_specification_v8_0_3_0.json -g csharp --skip-validate-spec -o <your output directory>To compare to java generator run
java -jar modules\openapi-generator-cli\target\openapi-generator-cli.jar generate -i vi_json_openapi_specification_v8_0_3_0.json -g java --skip-validate-spec -o <your output directory>The fix uses memoization and continues the fix from 10152
The generated code is the same as before.