[python-fastapi] Fix: Skip sorting of path operations (#22163)#22166
Merged
wing328 merged 2 commits intoOpenAPITools:masterfrom Oct 18, 2025
Merged
[python-fastapi] Fix: Skip sorting of path operations (#22163)#22166wing328 merged 2 commits intoOpenAPITools:masterfrom
wing328 merged 2 commits intoOpenAPITools:masterfrom
Conversation
…2163) Make use of helpful code added in 243f501 to skip sorting of path parameters. In FastAPI, order matters, see link for details: https://fastapi.tiangolo.com/tutorial/path-params/?h=path#order-matters Issue: OpenAPITools#22163
Member
|
thanks for the PR can you please follow step 3 to update the samples? |
Reading comprehension is hard. I missed the part of step 3 where samples would be updated in response to the change I had previous submitted. Via this commit, update samples to match expectations. The order of various endpoint implementations is now changed in the sample, matchcing the order in the yaml files that created them.
Contributor
Author
|
My apologies for the oversight. I believe it is corrected now. |
Member
|
thanks for the fix, which has been merged |
6 tasks
Member
|
FYI. Merged #22522 to avoid log message (constructor) as it will appear in every generator |
rajvesh
pushed a commit
to rajvesh/openapi-generator
that referenced
this pull request
Dec 25, 2025
…2163) (OpenAPITools#22166) * [python-fastapi] Fix: Skip sorting of path operations (OpenAPITools#22163) Make use of helpful code added in 243f501 to skip sorting of path parameters. In FastAPI, order matters, see link for details: https://fastapi.tiangolo.com/tutorial/path-params/?h=path#order-matters Issue: OpenAPITools#22163 * Update samples after previous commit Reading comprehension is hard. I missed the part of step 3 where samples would be updated in response to the change I had previous submitted. Via this commit, update samples to match expectations. The order of various endpoint implementations is now changed in the sample, matchcing the order in the yaml files that created them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make use of helpful code added in
243f501 to skip sorting of path parameters. In FastAPI, order matters, see link for details: https://fastapi.tiangolo.com/tutorial/path-params/?h=path#order-matters
fixes #22163
Modified FastAPI's configuration, setting setSkipSortingOperations to True so FastAPI path operations will not be reordered.
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)