fix: Format Date/DateTime Query Parameters in exploded, non-container Parameter#22268
Conversation
|
Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors. Let me know if you need help fixing it. |
|
please follow step 3 in the pr checklist to fix https://github.com/OpenAPITools/openapi-generator/actions/runs/19011794828/job/54333510734?pr=22268 |
e492c1f to
f00dc1b
Compare
…-container exploded query parameter
f00dc1b to
5f0a518
Compare
|
Thanks for the advice @wing328, I adjusted the whitespace in the templates so the samples do not change. Also I tried correctly setting the commit author, lmk if that worked. |
|
Hi @wing328, friendly reminder to check this out once again. @timgrohmann Thanks for the work! We are also running into this in one of our apps. |
|
let's give it a try will try to add a test or 2 later |
…-container exploded query parameter (OpenAPITools#22268)
Fixes #22267
Tagging the committee as stated in the checklist: @TiFu @akehir @petejohansonxo @amakhrov @davidgamero @mkusaka @joscha
Change Description
Externalise the query parameter assignment into a separate mustache script and call it in the original place as well as while setting a
exploded: true, non-container param.PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)