Skip to content

Comments

ensure-up-to-date - add r and javascript#2227

Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom
karismann:ensure-up-to-date-add-r-javascript
Mar 7, 2019
Merged

ensure-up-to-date - add r and javascript#2227
wing328 merged 1 commit intoOpenAPITools:masterfrom
karismann:ensure-up-to-date-add-r-javascript

Conversation

@karismann
Copy link
Contributor

@karismann karismann commented Feb 24, 2019

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh, ./bin/security/{LANG}-petstore.sh and ./bin/openapi3/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.

Description of the PR

Add R and JavaScript in ensure-up-to-date sample scripts

for #80

@wing328
Copy link
Member

wing328 commented Mar 7, 2019

@karismann thanks for the PR. We can definitely include these.

(FYI. The R integration tests are run via https://github.com/wing328/petstore-r-client instead.

@wing328 wing328 added this to the 4.0.0 milestone Mar 7, 2019
@wing328 wing328 merged commit 6a9117e into OpenAPITools:master Mar 7, 2019
@karismann karismann deleted the ensure-up-to-date-add-r-javascript branch March 7, 2019 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants