[php][php-nextgen] fix return type if empty and non-empty responses are mixed#22322
Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom Nov 10, 2025
Merged
Conversation
5 tasks
rajvesh
pushed a commit
to rajvesh/openapi-generator
that referenced
this pull request
Dec 25, 2025
kocsismate
reviewed
Jan 26, 2026
| } else { | ||
| String phpReturnType = String.join("|", phpReturnTypeOptions); | ||
| String docReturnType = String.join("|", docReturnTypeOptions); | ||
| if (hasEmptyResponse) { |
There was a problem hiding this comment.
@wing328 I have bumped into an error when a response has a nullable union return type: then the native return type will include the following: ?A|B which is invalid syntax. As far as I remember, the same happens with other symbols (e.g. parameters maybe?).
Contributor
Author
There was a problem hiding this comment.
Can you create an issue with a minimal OpenAPI spec to reproduce that?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue when you have an endpoint that either returns a response with data or an empty response (e.g., empty response on success but an error message on error, or the other way around). The return type would be annotated with the non-empty response types. If an empty response was encountered, null would be returned which throws an error because that's not a valid return type.
I added null to the possible return types if any of the responses have no schema.
Fixes #21359.
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)@jebentier @dkarlovi @mandrean @jfastnacht @ybelenko @renepardon