[typescript-node] Fixes generation when parent contains TypeScript primitive#22401
Merged
macjohnny merged 4 commits intoOpenAPITools:masterfrom Dec 8, 2025
Merged
[typescript-node] Fixes generation when parent contains TypeScript primitive#22401macjohnny merged 4 commits intoOpenAPITools:masterfrom
macjohnny merged 4 commits intoOpenAPITools:masterfrom
Conversation
fetis
commented
Nov 20, 2025
| return "string".equals(lowerType) || | ||
| "boolean".equals(lowerType) || | ||
| "number".equals(lowerType) || | ||
| "any".equals(lowerType) || |
Contributor
Author
There was a problem hiding this comment.
any value comes when the schema has additionalProperties: true
Contributor
Author
|
I need help with CircleCI tests. The error looks disconnected from my changes |
Member
|
@fetis can you merge the most recent master branch? |
Contributor
Author
|
@macjohnny updated from the master |
Contributor
Author
|
@macjohnny any update? I see random failures on CI, but I cannot connect them with my changes |
Member
|
can you merge the master branch again? that one seems green for all CI workflows |
Contributor
Author
|
@macjohnny merged. All nodes are green now :) |
lucy66hw
pushed a commit
to lucy66hw/openapi-generator
that referenced
this pull request
Dec 16, 2025
…imitive (OpenAPITools#22401) * fixes parents when schema has additional properties * exclude primitive types from parent property
rajvesh
pushed a commit
to rajvesh/openapi-generator
that referenced
this pull request
Dec 25, 2025
…imitive (OpenAPITools#22401) * fixes parents when schema has additional properties * exclude primitive types from parent property
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the schema contains
additionalProperties, thetypevalue of it was transferred into theparentproperty of the model. This led to incorrect code generation, like thisThis fix filters out the known TS primitives from the parent property.
Closes #14661
Mentioning the TypeScript committee:
@TiFu @taxpon @sebastianhaas @kenisteward @Vrolijkx @macjohnny @topce @akehir @petejohansonxo @amakhrov @davidgamero @mkusaka @joscha
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)