[cpp-rest] Fixes segfault for nullable strings#22405
[cpp-rest] Fixes segfault for nullable strings#22405wing328 merged 1 commit intoOpenAPITools:masterfrom
Conversation
|
I like the idea, however we have |
|
@muttleyxd The sdk's min compile target listed in cmake-lists is 11, should we update it? Looks like sometimes cpp11 will work, unless you use FYI the library already depends on boost, and the compile time for this header should be the same as std. I wasn't sure how far back we really want to go in terms of support so I did the safe thing. I guess I will change it. |
|
Oh, I haven't looked into this generator recently (in last few years 😅), I guess if we keep it at C++11 and Boost is already there, then it's fine |
|
it's ok :) I will do whatever people want me to do. Personally I don't think consumers of my sdk will be using anything older than 17... |
|
if no further feedback, i'll merge this PR tomorrow or Wed. thanks again for the contribution |
Fixes #22404
Was seeing segfaults on nullable fields that were actually set to null at runtime.
Switches to boost optional, which seems to be the best way to go, or I can add guards instead of we prefer that.
@ravinikam @stkrwork @etherealjoy @MartinDelille @muttleyxd @aminya