[typescript-rxjs] add class name as prefix to enum name#2242
Merged
wing328 merged 2 commits intoOpenAPITools:masterfrom Mar 1, 2019
denyo:typescript-rxjs-namespaces
Merged
[typescript-rxjs] add class name as prefix to enum name#2242wing328 merged 2 commits intoOpenAPITools:masterfrom denyo:typescript-rxjs-namespaces
wing328 merged 2 commits intoOpenAPITools:masterfrom
denyo:typescript-rxjs-namespaces
Conversation
|
👍 Thanks for opening this issue! The team will review the labels and make any necessary changes. |
Member
Upgrade NoteThe class name is added as a prefix to the enum naming: Before: |
wing328
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.sh,./bin/security/{LANG}-petstore.shand./bin/openapi3/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,. Default:3.4.x,4.0.xmaster.Description of the PR
Based on the discussion of #1947 and copied from #2123 this solves the issue of identical enums exported within barrels by prefixing them with the name of the interface. The namespace issue mentioned in the ticket / pr wasn't an issue for
typescript-rxjsbut it looks like enums weren't properly generated in the past as the diff of the petstore samples shows.@TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @nicokoenig (2018/09) @topce (2018/10)