[php][php-nextgen] Cleanup api authentication code when using api keys in cookies or supporting multiple authentication methods#22433
Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom Nov 26, 2025
Conversation
…s in cookies or supporting multiple authentication methods
lucy66hw
pushed a commit
to lucy66hw/openapi-generator
that referenced
this pull request
Dec 16, 2025
…s in cookies or supporting multiple authentication methods (OpenAPITools#22433)
rajvesh
pushed a commit
to rajvesh/openapi-generator
that referenced
this pull request
Dec 25, 2025
…s in cookies or supporting multiple authentication methods (OpenAPITools#22433)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using an API key in a cookie, the php generator would previously generate the following code:
This code does nothing and therefore it's removed from this PR.
When multiple authentication methods were supported, they were added below each other without a single newline:
For methods that require no authentication, it would have multiple empty lines instead. This PR adds a newline after each authentication method instead. If none are present, then there's just one empty line. (see samples if this is unclear)
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)@jebentier @dkarlovi @mandrean @jfastnacht @ybelenko @renepardon