[Rust] Implement support for multipart file uploads for reqwest-async and reqwest-trait#22454
Merged
wing328 merged 2 commits intoOpenAPITools:masterfrom Nov 30, 2025
Conversation
Member
|
Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors. Let me know if you need help fixing it. |
a8236cc to
7c630ad
Compare
Contributor
Author
|
Oops, I forgot I was on a different laptop! Fixed, thanks! |
lucy66hw
pushed a commit
to lucy66hw/openapi-generator
that referenced
this pull request
Dec 16, 2025
… and reqwest-trait (OpenAPITools#22454) * feat(Rust): Add support for multipart file uploads in reqwest generators * chore: Regen relevant samples affected by the updated multipart support
rajvesh
pushed a commit
to rajvesh/openapi-generator
that referenced
this pull request
Dec 25, 2025
… and reqwest-trait (OpenAPITools#22454) * feat(Rust): Add support for multipart file uploads in reqwest generators * chore: Regen relevant samples affected by the updated multipart support
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've updated the samples and related configs to enable
useAsyncFileStreamwhere necessary.I've also sneaked in a fix for incorrect code generation, which I'd like someone to have a closer look:
https://github.com/OpenAPITools/openapi-generator/compare/master...whirm:feat/rust-request-multipart-file-uploads?expand=1#diff-560675cd0a01bd295018250fac1197e39c9cb662a6ccc8e15785d94f2b2ca769L423-R435
Now only primitive type parts get stringified with
.to_string(), the rest are serialized to json. AFAICT that's the way to go.PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)closes: #17822
@frol, @farcaller, @richardwhiuk, @paladinzh, @jacob-pro, @linxGnu Ready to review!