[kotlin-client] ALL: Prevent HTML-escaping of operation parameter defaults#22506
Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom Dec 14, 2025
Conversation
337c1da to
644643b
Compare
Contributor
|
Hello @okarmazin, I presume the same issue is present also in other kotlin generators? |
6 tasks
The enum constants may be backtick-escaped reserved words (e.g. "DocumentDisposition.`inline`"). Mustache html-escapes the backticks, leading to invalid code such as "DocumentDisposition.`inline`". This change adjusts all Kotlin client Mustache templates to pass the values through as raw values.
644643b to
2cbc560
Compare
Contributor
Author
I don't know, but the only usages of |
Contributor
|
Just checked - this seems to work correctly in kotlin-spring generator. |
lucy66hw
pushed a commit
to lucy66hw/openapi-generator
that referenced
this pull request
Dec 16, 2025
…APITools#22506) The enum constants may be backtick-escaped reserved words (e.g. "DocumentDisposition.`inline`"). Mustache html-escapes the backticks, leading to invalid code such as "DocumentDisposition.`inline`". This change adjusts all Kotlin client Mustache templates to pass the values through as raw values.
rajvesh
pushed a commit
to rajvesh/openapi-generator
that referenced
this pull request
Dec 25, 2025
…APITools#22506) The enum constants may be backtick-escaped reserved words (e.g. "DocumentDisposition.`inline`"). Mustache html-escapes the backticks, leading to invalid code such as "DocumentDisposition.`inline`". This change adjusts all Kotlin client Mustache templates to pass the values through as raw values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22505
Kotlin client API templates now pass through enum defaults of operation parameters as raw values. Prevents incorrect HTML-escaping of Kotlin backticks if the default enum constant is a reserved Kotlin word.
Old output:
Fixed output:
New tests should cover all present and future clients that generate enum classes.
This PR builds upon #22504 and I'll rebase when that gets merged.
The GitHub diff viewer is not very good. This is a single-character change in multiple templates that replaces
{{enumDefaultValue}}with{{&enumDefaultValue}}PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)