Skip to content

swift4: handle collection params in path#2259

Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom
jacobweber:swift4ArrayParams
Mar 19, 2019
Merged

swift4: handle collection params in path#2259
wing328 merged 1 commit intoOpenAPITools:masterfrom
jacobweber:swift4ArrayParams

Conversation

@jacobweber
Copy link
Contributor

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh, ./bin/security/{LANG}-petstore.sh and ./bin/openapi3/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language. @jgavris (2017/07) @ehyche (2017/08) @Edubits (2017/09) @jaz-ah (2017/09) @d-date (2018/03)

Description of the PR

Handle path params that are collections in swift4, for #2125.

Assumes the collectionFormat is CSV for now, although that could be added as a parameter.

I'm not very familiar with Swift, so please let me know if this could be improved.

@jacobweber jacobweber changed the title Handle collection params in path (assume csv for now). Handle collection params in path Feb 27, 2019
@jacobweber jacobweber changed the title Handle collection params in path swift4: handle collection params in path Feb 27, 2019
@jacobweber
Copy link
Contributor Author

Just to clarify: my change only supports CSV for path parameters, because the existing code only supports CSV for query/form parameters. I didn't want to change too much. But ideally it would support other formats for any parameter type.

@wing328
Copy link
Member

wing328 commented Mar 12, 2019

The change looks good to me. If no further question, I'll merge it tomorrow (Wed)

@wing328 wing328 added this to the 4.0.0 milestone Mar 12, 2019
@wing328 wing328 merged commit 3320d3c into OpenAPITools:master Mar 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments