Skip to content

fix: Fix rust-server model generation following serde_valid upgrade#22737

Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom
dsteeley:serde_valid_fixes
Jan 20, 2026
Merged

fix: Fix rust-server model generation following serde_valid upgrade#22737
wing328 merged 1 commit intoOpenAPITools:masterfrom
dsteeley:serde_valid_fixes

Conversation

@dsteeley
Copy link
Contributor

@dsteeley dsteeley commented Jan 19, 2026

Add additional models to rust-server validation support following the upgrade to serde_valid 2.0. Also remove some duplicate #[cfg_attr(feature = "validate", validate)] .

I've attempted to reconcile the whitespace differences but leaving as I've not got further time to spend on this. I don't think they result in any functional changes.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request. @frol (2017/07) @farcaller (2017/08) @richardwhiuk (2019/07) @paladinzh (2020/05) @jacob-pro (2022/10) @dsteeley (2025/07)

Summary by cubic

Fixes rust-server model generation after upgrading to serde_valid 2.0 by adding required composited validation support and removing duplicate validate attributes. Restores clean compilation and tidier generated code.

  • Bug Fixes
    • Implemented serde_valid::validation::ValidateCompositedMinLength for newtype models when the validate feature is enabled.
    • Prevented duplicate #[cfg_attr(feature = "validate", validate)] on fields by guarding nested validation emission and placing the validate partial once for both required and optional fields.
    • Regenerated rust-server samples; removes duplicate validate attributes and includes minor whitespace-only changes.

Written for commit 0554ae7. Summary will update on new commits.

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 5 files

@wing328 wing328 merged commit c34d593 into OpenAPITools:master Jan 20, 2026
16 of 19 checks passed
@wing328 wing328 added this to the 7.20.0 milestone Jan 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants