Generate request config typescript fetch v2#22815
Merged
wing328 merged 2 commits intoOpenAPITools:masterfrom Jan 26, 2026
Merged
Generate request config typescript fetch v2#22815wing328 merged 2 commits intoOpenAPITools:masterfrom
wing328 merged 2 commits intoOpenAPITools:masterfrom
Conversation
…21708 (OpenAPITools#21709) * feat(types): Add request configuration method to {{classname}}Interface * update docs and samples * refactor: change naming to better mirror openapi context * docs: update typescript-fetch
Contributor
Author
|
My last pr broke main (#21709). I made the necessary changes starting from my original commit. |
6 tasks
Contributor
Author
|
@TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02) @davidgamero (2022/03) @mkusaka (2022/04) @joscha (2024/10) |
Contributor
Author
|
fixes: #21708 |
Member
|
let's give it a try we can further update it with separate PRs if needed |
6 tasks
kingofdisasterr
pushed a commit
to kingofdisasterr/openapi-generator
that referenced
this pull request
Jan 27, 2026
* Add create requestOpts method to {{classname}}Interface OpenAPITools#21708 (OpenAPITools#21709)
* feat(types): Add request configuration method to {{classname}}Interface
* update docs and samples
* refactor: change naming to better mirror openapi context
* docs: update typescript-fetch
* feat(types): Add request configuration method to {{classname}}Interface
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original pr that broke master branch: #21709
This PR splits some logic, instead of creating/building the request inline and sending it instantly we now use a function to do this. Functionally there should be no changes.
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)Summary by cubic
Introduces per-operation request option builders in the TypeScript Fetch generator, separating request construction from sending. Adds flexibility for pre-inspecting or customizing requests with no runtime behavior change.
Written for commit bb42080. Summary will update on new commits.