Skip to content

Generate request config typescript fetch v2#22815

Merged
wing328 merged 2 commits intoOpenAPITools:masterfrom
azertyalex:generate-request-config-typescript-fetch-v2
Jan 26, 2026
Merged

Generate request config typescript fetch v2#22815
wing328 merged 2 commits intoOpenAPITools:masterfrom
azertyalex:generate-request-config-typescript-fetch-v2

Conversation

@azertyalex
Copy link
Contributor

@azertyalex azertyalex commented Jan 26, 2026

Original pr that broke master branch: #21709

This PR splits some logic, instead of creating/building the request inline and sending it instantly we now use a function to do this. Functionally there should be no changes.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Summary by cubic

Introduces per-operation request option builders in the TypeScript Fetch generator, separating request construction from sending. Adds flexibility for pre-inspecting or customizing requests with no runtime behavior change.

  • Refactors
    • Adds RequestOpts methods to generated interfaces and classes, returning runtime.RequestOpts.
    • Raw methods now call request() with options from RequestOpts; public APIs remain the same.
    • Removes initOverrides from RequestOpts signatures; pass initOverrides only to raw/request calls.
    • Updates all TypeScript Fetch samples and docs to use the new RequestOpts pattern.

Written for commit bb42080. Summary will update on new commits.

azertyalex and others added 2 commits January 26, 2026 15:17
…21708 (OpenAPITools#21709)

* feat(types): Add request configuration method to {{classname}}Interface

* update docs and samples

* refactor: change naming to better mirror openapi context

* docs: update typescript-fetch
@azertyalex
Copy link
Contributor Author

azertyalex commented Jan 26, 2026

My last pr broke main (#21709). I made the necessary changes starting from my original commit.
Very sorry for the inconvenience. I hope my contribution will still be looked at if you'll have me

@azertyalex azertyalex marked this pull request as ready for review January 26, 2026 14:44
@azertyalex
Copy link
Contributor Author

@TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02) @davidgamero (2022/03) @mkusaka (2022/04) @joscha (2024/10)

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 50 files

@azertyalex
Copy link
Contributor Author

fixes: #21708

@wing328
Copy link
Member

wing328 commented Jan 26, 2026

let's give it a try

we can further update it with separate PRs if needed

@wing328 wing328 merged commit 422e30a into OpenAPITools:master Jan 26, 2026
34 checks passed
kingofdisasterr pushed a commit to kingofdisasterr/openapi-generator that referenced this pull request Jan 27, 2026
* Add create requestOpts method to {{classname}}Interface OpenAPITools#21708 (OpenAPITools#21709)

* feat(types): Add request configuration method to {{classname}}Interface

* update docs and samples

* refactor: change naming to better mirror openapi context

* docs: update typescript-fetch

* feat(types): Add request configuration method to {{classname}}Interface
@wing328 wing328 added this to the 7.20.0 milestone Feb 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants