Skip to content

[php][php-nextgen] Fix nullability when multiple response types are possible#22827

Merged
wing328 merged 2 commits intoOpenAPITools:masterfrom
JulianVennen:nullable-union-types
Jan 27, 2026
Merged

[php][php-nextgen] Fix nullability when multiple response types are possible#22827
wing328 merged 2 commits intoOpenAPITools:masterfrom
JulianVennen:nullable-union-types

Conversation

@JulianVennen
Copy link
Contributor

@JulianVennen JulianVennen commented Jan 27, 2026

Fixes #22817

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@jebentier @dkarlovi @mandrean @jfastnacht @ybelenko @renepardon


Summary by cubic

Fixes nullability handling for PHP Nextgen when an operation can return multiple types. Generates "type1|type2|null" instead of invalid "?type1|type2", and keeps "?T" for single types; addresses #22817.

  • Bug Fixes
    • For endpoints with multiple response schemas plus an empty response, return types now use unions with null (e.g., integer|string|null). Single-type responses remain "?T".
    • Added a test and sample spec (issue_22817.yaml) to assert correct generation and prevent "?union" output.

Written for commit 56d373d. Summary will update on new commits.

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

@wing328 wing328 merged commit 6022e4e into OpenAPITools:master Jan 27, 2026
15 checks passed
@kocsismate
Copy link

Thank you for the fix!

kingofdisasterr pushed a commit to kingofdisasterr/openapi-generator that referenced this pull request Jan 27, 2026
…ossible (OpenAPITools#22827)

* [php][php-nextgen] Fix nullability when multiple response types are possible

* [php][php-nextgen] Fix test
@wing328 wing328 added this to the 7.20.0 milestone Feb 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] [php-nextgen] Invalid syntax with nullable union return types

3 participants