[go] Fix text escaping in example code generation#22841
Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom Jan 30, 2026
Merged
[go] Fix text escaping in example code generation#22841wing328 merged 1 commit intoOpenAPITools:masterfrom
wing328 merged 1 commit intoOpenAPITools:masterfrom
Conversation
Member
Member
|
thanks for the PR may i know if you've a minimal spec to reproduce the issue so that we can use to more easily confirm the fix? |
Wrap example values with escapeText() to properly escape special characters in generated Go client code examples Signed-off-by: Julien Pivotto <291750+roidelapluie@users.noreply.github.com>
1918496 to
9172ce8
Compare
Member
|
did a test locally and the change looks good |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wrap example values with escapeText() to properly escape special characters in generated Go client code examples
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)Summary by cubic
Fixes string escaping in generated Go client examples to prevent compilation errors when example values contain special characters. Example strings (including emails) are now passed through escapeText().
Written for commit 9172ce8. Summary will update on new commits.