[BUG] [KOTLIN-SPRING] @HttpExchange in declarative interface does not support property placeholders#22882
Merged
wing328 merged 4 commits intoOpenAPITools:masterfrom Feb 4, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #22879 for description of the issue. Basically the gist is:
@HttpExchangeannotation and replace it with the generated BASE_PATH property.@HttpExchangeannotation viarequestMappingModeproperty. Hence allowing entirely custom base path if so desiredTo make it clearer - as of now, generating with
requestMappingMode=api_interfacebasically produces non-working code unless extra steps are taken when instantiating the interface by addingStringValueResolverviaHttpServiceProxyFactory.builder()PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)Summary by cubic
Fixes placeholder usage in Kotlin Spring @HttpExchange by switching to a generated BASE_PATH constant and optional interface-level mapping. This makes generated clients work with HttpServiceProxyFactory and avoids unresolved placeholders. Fixes #22879.
Written for commit 121956c. Summary will update on new commits.