update python sdk [ strip any directory traversal ]#22953
Closed
padznich wants to merge 2 commits intoOpenAPITools:masterfrom
Closed
update python sdk [ strip any directory traversal ]#22953padznich wants to merge 2 commits intoOpenAPITools:masterfrom
padznich wants to merge 2 commits intoOpenAPITools:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
2 issues found across 74 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="docs/generators/swift5.md">
<violation number="1" location="docs/generators/swift5.md:10">
P2: The docs now claim the swift5 generator is STABLE, but the generator metadata in code still marks it DEPRECATED, causing a mismatch between docs and actual generator status.</violation>
</file>
<file name="docs/generators/kotlin-server.md">
<violation number="1" location="docs/generators/kotlin-server.md:265">
P2: Documentation now claims Polymorphism/allOf/oneOf are unsupported, but KotlinServerCodegen explicitly includes these schema support features, creating a mismatch that can mislead users.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Member
|
looks like your PR is not based on the latest master can you please file a new one based on the latest master or merge the latest master into your branch (and update both samples and docs)? cc @cbornet (2017/09) @tomplus (2018/10) @krjakbrjak (2023/02) @fa0311 (2023/10) @multani (2023/10) |
Strip any directory traversal
67cf2a8 to
215cb98
Compare
6 tasks
Member
|
FYI. Filed #22965 (you listed as co-author) |
Member
|
Merged via #22965 so closing this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Strip any directory traversal
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
Summary by cubic
Updated Python SDK to safely save downloaded files by stripping path components from Content-Disposition filenames. Regenerated generator docs and samples to reflect the change.
Written for commit 215cb98. Summary will update on new commits.