Update tests to reduce size for webclient samples#23185
Merged
Conversation
Contributor
There was a problem hiding this comment.
1 issue found across 187 files
Note: This PR contains a large number of files. cubic only reviews up to 75 files per PR, so some files may not have been reviewed.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="samples/client/petstore/java/webclient-springBoot4-jackson3/README.md">
<violation number="1" location="samples/client/petstore/java/webclient-springBoot4-jackson3/README.md:9">
P2: The new README text incorrectly tells users to use an API key, but this generated client is documented and demonstrated with OAuth (`petstore_auth`) only.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| - Generator version: 7.21.0-SNAPSHOT | ||
|
|
||
| This spec is mainly for testing Petstore server and contains fake endpoints, models. Please do not use this for any other purpose. Special characters: \" \\ | ||
| This is a sample server Petstore server. For this sample, you can use the api key `special-key` to test the authorization filters. |
Contributor
There was a problem hiding this comment.
P2: The new README text incorrectly tells users to use an API key, but this generated client is documented and demonstrated with OAuth (petstore_auth) only.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At samples/client/petstore/java/webclient-springBoot4-jackson3/README.md, line 9:
<comment>The new README text incorrectly tells users to use an API key, but this generated client is documented and demonstrated with OAuth (`petstore_auth`) only.</comment>
<file context>
@@ -6,7 +6,7 @@ OpenAPI Petstore
- Generator version: 7.21.0-SNAPSHOT
-This spec is mainly for testing Petstore server and contains fake endpoints, models. Please do not use this for any other purpose. Special characters: \" \\
+This is a sample server Petstore server. For this sample, you can use the api key `special-key` to test the authorization filters.
</file context>
Suggested change
| This is a sample server Petstore server. For this sample, you can use the api key `special-key` to test the authorization filters. | |
| This is a sample Petstore server. For this sample, configure OAuth (`petstore_auth`) to test the authorization filters. |
davidricodias
pushed a commit
to davidricodias/openapi-generator
that referenced
this pull request
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a follow up PR to #23031
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)Summary by cubic
Reduce the webclient Java sample used in tests by switching to a minimal Petstore spec (addPet only), cutting generated files and speeding up CI.
bin/configs/java-webclient-springBoot4-jackson3.yamltomodules/openapi-generator/src/test/resources/3_0/petstore-addpet-only.yaml.PetApi.addPet; remove other Petstore APIs/models/docs to shrink output.http://petstore.swagger.io/v2and refresh descriptions in generated headers/README.Pet.photoUrlsis nowList<String>;Category.nameis optional; minor doc tweaks for Tag/Category.PetApi; drop references to removed APIs.Written for commit 74b151e. Summary will update on new commits.