Skip to content

Comments

Add .travis.yml and Gemfile.lock to ruby security test folder#2330

Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom
ota42y:feature/update_sequrity-test
Mar 8, 2019
Merged

Add .travis.yml and Gemfile.lock to ruby security test folder#2330
wing328 merged 1 commit intoOpenAPITools:masterfrom
ota42y:feature/update_sequrity-test

Conversation

@ota42y
Copy link
Contributor

@ota42y ota42y commented Mar 8, 2019

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh, ./bin/security/{LANG}-petstore.sh and ./bin/openapi3/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

@cliffano (2017/07) @zlx (2017/09) @autopp (2019/02)

When we run ./bin/security/ruby-client-petstore.sh, we got changes.
I think someone fogot to commit it.

When we run `./bin/security/ruby-client-petstore.sh`, we got changes.
I think someone fogot to commit it.
@autopp
Copy link
Contributor

autopp commented Mar 8, 2019

Thanks for PR. LGTM!

@wing328
Copy link
Member

wing328 commented Mar 8, 2019

@ota42y thanks for the PR. Eventually, we'll move the security tests to another repository instead to reduce the project size and manual steps required when submitting a PR.

@wing328 wing328 merged commit 882186f into OpenAPITools:master Mar 8, 2019
@wing328 wing328 added this to the 4.0.0 milestone Mar 8, 2019
@ota42y ota42y deleted the feature/update_sequrity-test branch March 8, 2019 08:01
jimschubert added a commit to jimschubert/openapi-generator that referenced this pull request Mar 9, 2019
* master: (758 commits)
  Add support for free form requests (OpenAPITools#2288)
  [typescript-rxjs] drop unneeded function wrapping  (OpenAPITools#2332)
  [typescript-fetch] Guard array mapping against undefined on optional array model properties (OpenAPITools#2324)
  Fix regex in Python server model code (OpenAPITools#2314)
  Add .travis.yml and Gemfile.lock to ruby security test folder (OpenAPITools#2330)
  Add a link to CSDN article (OpenAPITools#2331)
  [Maven] fix Spaces in Windows user path breaks build on test goal (OpenAPITools#2318)
  [PHP] fix bad links in Model docs (OpenAPITools#2316)
  [java]: fix datatype for non-multipart file request body (OpenAPITools#2271)
  Removed JFCote from core team (OpenAPITools#2315)
  [R sample] fix CircleCI error of outdated sample (OpenAPITools#2313)
  [Java] Bean Validation for decimalmin/max incorrect when exclusive set (OpenAPITools#2115)
  Java Spring : fix defaultValue annotation double quoted in api operation (OpenAPITools#2267)
  Java RESTEASY : fix defaultValue annotation double quoted in api operation (OpenAPITools#2268)
  [PHP] Username checks OpenAPITools#1408 (OpenAPITools#1892)
  [typescript-fetch] remove namespaces in enums (OpenAPITools#2123)
  [java-server-msf4j] fix and upgrade (OpenAPITools#2303)
  fix test script path in CONTRIBUTING.md (OpenAPITools#2290)
  Dart queryargs (OpenAPITools#2250)
  add Blueplanet language (OpenAPITools#2184)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants