ci: upload openapi-generator-cli.jar as GitHub Release asset#23524
Open
sakshar2303 wants to merge 1 commit intoOpenAPITools:masterfrom
Open
ci: upload openapi-generator-cli.jar as GitHub Release asset#23524sakshar2303 wants to merge 1 commit intoOpenAPITools:masterfrom
sakshar2303 wants to merge 1 commit intoOpenAPITools:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
1 issue found across 1 file
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name=".github/workflows/maven-release.yml">
<violation number="1" location=".github/workflows/maven-release.yml:110">
P2: The workflow uploads an asset to a GitHub Release without ensuring the Release exists for the tag, so tag-triggered runs can fail when no Release has been created yet.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
## Summary
Adds a new
upload-release-assetjob to the Maven release workflow thatuploads
openapi-generator-cli.jaras an asset to each GitHub Release tag.Motivation
Tools like aqua (a declarative CLI version
manager) rely on GitHub Release assets to install and manage CLI tools.
Since
openapi-generator-cli.jarwas only published to Maven Central and notattached to GitHub Releases, it was not possible to manage it via aqua or
similar GitHub-Releases-based version managers.
This change makes it possible to register
openapi-generator-cliin theaqua registry, following the same
pattern already established by tools like
ktfmt.Changes
tags: 'v*'trigger so the workflow also runs on version tag pushescontentspermission towritein thepublishjob to allowuploading release assets
upload-release-assetjob that:openapi-generator-cli-{version}.jarRelated Issue
Closes #23519
Summary by cubic
Attach
openapi-generator-cli.jarto each GitHub Release so the CLI can be installed via tools likeaqua. Adds a tag-triggered job that builds and uploads the JAR as a release asset.v*tags.upload-release-assetjob runs only on tag pushes.openapi-generator-cli-{version}.jarto the matching GitHub Release viagh, withcontents: writepermission.Written for commit adda3dc. Summary will update on new commits.