Skip to content

[PYTHON][bugfix]Fix python model dict array generation#23538

Open
ilayu-blip wants to merge 1 commit intoOpenAPITools:masterfrom
ilayu-blip:python-sdk-models-array-bug
Open

[PYTHON][bugfix]Fix python model dict array generation#23538
ilayu-blip wants to merge 1 commit intoOpenAPITools:masterfrom
ilayu-blip:python-sdk-models-array-bug

Conversation

@ilayu-blip
Copy link
Copy Markdown

@ilayu-blip ilayu-blip commented Apr 14, 2026

This fixes issue #23508
The approach that was taken is copying the 'python-pydantic-v1' model_generic approach .

"{{{name}}}": {
                _k: [{{{items.items.dataType}}}.from_dict(_item) for _item in _v] if _v is not None else None
                for _k, _v in obj["{{{baseName}}}"].items()
            }
            if obj.get("{{{baseName}}}") is not None
            else None{{^-last}},{{/-last}}

The main difference is that {{{name}}} was replaced with {{{baseName}}} because the key in the dict of the 'python' and 'python-fastapi' was baseName.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@cbornet (2017/09) @tomplus (2018/10) @krjakbrjak (2023/02) @fa0311 (2023/10) @multani (2023/10)


Summary by cubic

Fixes incorrect codegen for Python models that deserialize dicts of arrays, aligning python and python-fastapi with python-pydantic-v1. Fixes #23508.

  • Bug Fixes
    • Correctly generate from_dict for map[str, list[Model]] fields by iterating obj["baseName"] with a None guard and mapping each item via Model.from_dict.
    • Use the dict’s actual key (baseName) instead of the model name to match existing python/python-fastapi behavior.
    • Regenerated Python samples and added a minor .gitignore entry.

Written for commit 2151943. Summary will update on new commits.

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 11 files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] [PYTHON] Code generation of model for arrays

1 participant